Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically check the domain and message hashes sent to Ledger matches the ones in the simulation #195

Open
zchn opened this issue May 10, 2024 · 0 comments

Comments

@zchn
Copy link
Collaborator

zchn commented May 10, 2024

Recently, due to a bug fixed in https://github.com/base-org/contract-deployments/pull/166/files, we were getting different hashes sent to the ledger devices compared to the ones in the Tenderly simulation. It would be great if we can detect this by automatically checking the domain and message hashes sent to Ledger matches the ones in the simulation. This may require us to migrate away from Tenderly to a more programmatically parsable one.

See https://www.notion.so/oplabs/PM-48-Wrong-message-hash-sent-to-Signers-Ledger-during-an-L2-contract-upgrade-c893131d9daa440bad6fe09c848db54d for the original postmortem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant