Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typechain glob not matching to files on windows #271

Closed
zemse opened this issue Aug 10, 2020 · 4 comments
Closed

Typechain glob not matching to files on windows #271

zemse opened this issue Aug 10, 2020 · 4 comments

Comments

@zemse
Copy link
Contributor

zemse commented Aug 10, 2020

The repo contains the following script for typechain.

"typechain": "typechain --target ethers-v5 --outDir build/typechain 'build/artifacts/**/*.json'"

This generates typechain outputs on macos, linux but on windows the glob matches to 0 files and hence doesn't generate any typings file.

I've created a github workflow seperate jobs for macos-latest, ubuntu-latest and windows-latest. There the tests pass for macos, ubuntu while fail for windows giving typescript error (which is that it didn't find a typing file).

Run link: https://github.com/KMPARDS/contract-template/runs/967467001

Screenshots:

Screenshot 2020-08-10 at 9 37 20 PM

@snaketh4x0r
Copy link

I m facing the same issue
I m using this
typechain --target truffle './build/**/*.json'
although currently I have booted a linux distro but I hope this gets fixed.
Typings files are generated but they don't have any contract interfaces generated correctly

@meryuhi
Copy link

meryuhi commented Sep 12, 2020

I found a workaround is to remove the single quotes of the glob matching path, just use like

typechain --target truffle-v5 build/contracts/**/*.json

@rafinskipg
Copy link
Contributor

rafinskipg commented Mar 30, 2021

Use this for both linux and windows support \" in package.json

typechain --target truffle-v5 \"build/contracts/**/*.json\"

@krzkaczor
Copy link
Member

This doesn't seem to a TypeChain bug but rather a Windows oddity.

Closing for now. If someone has an idea how we can improve this on our side LMK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants