Upgrade web3 to 1.0.0-beta.48

[cryptokat]

fix #135

[coveralls]

Pull Request Test Coverage Report for Build 181

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 88.522%

---

Totals
Change from base Build 177:	0.02%
Covered Lines:	393
Relevant Lines:	428

---

💛 - Coveralls

[eswarasai]

@cryptokat -- I think this PR is looking good to generate typings for web3@1.0.0-beta with default typings. But dropping the legacy support isn't really good idea at this stage as there might be lot of projects out there relying upon web3@0.20.x. I'm sure @krzkaczor will agree on this.

[cryptokat]

@eswarasai I decided to drop legacy support because of broken test/package-test that needs web3@1.0.0-beta.48 to be working, otherwise the dependencies on the sub packages of web3 such as web3-core will cause compilation error.

[krzkaczor]

Dropping legacy support is a no-go. Personally, I feel like web3 0.20.x is way more stable. Please revert the removal and tmrw I will help you fixing those failing tests (sorry it's late at night here).

[cryptokat]

@eswarasai @krzkaczor I reverted the removal of legacy support and fixed the error of package-test by excluding it from tsc compilation ddc6ae0 . Please have a look if that's alright.

[cryptokat]

In case that you are not aware of the error I mentioned above, here's the error I was getting from package-test before excluding it from tsc compilation:

[krzkaczor]

@cryptokat thanks! Frankly, I can't reproduce these problems that you were encountering but I think ignoring package-test in global tsconfig.json file makes sense.

[krzkaczor]

btw. i think this is slightly related to: #129

[krzkaczor]

@cryptokat @eswarasai PR looks fine for me. Did anyone of you tested it locally in your projects? I can merge this and publish new version today.

[eswarasai]

@krzkaczor -- I haven't tested this locally but the changes are looking good to me. I think we're missing a use case here where people might be using web3.js and the types from @types/web3 in their existing codebase and might not be easy for them to upgrade to the types within web3.js.

It might help devs to know what are the breaking changes within this release and what's not supported going forward in the README.md. Let me know if that makes sense. Thanks!

[krzkaczor]

@eswarasai yeah I imagine that people would use current ie. 0.3.11 version if they want to stick with older web3.js (without embedded types).

Yes, I will for sure leave a note about it in the changelog once it's merged. Thanks for reminder 😆

[krzkaczor]

Thank you for contributing! @cryptokat 🎉

Released as typechain@0.3.12

[iambryanwho]

In my project the Transaction parameter taken by the send() is the wrong interface after updating and following this thread. It requires all values to be passed in as seen here:

which leads to this error Im getting:

I think it has something to do with the Transaction object web3-core is importing in the type.d.ts file. The value should be of type any

Is anyone else encountering this issue? Fore reference I am using the latest web3 and typechain

[krzkaczor]

Hey @BryanWho could you create small repo example? I will get this sorted out

[iambryanwho]

@krzkaczor just sent you an invite to a skeleton repo

[iambryanwho]

Hey @krzkaczor any follow up on this: https://github.com/bryanwho/TypeChainTesting

[jimmygchen]

@BryanWho @krzkaczor I'm having the same issue mentioned above with the latest web3 and typechain. Please see this repo

https://github.com/jchen86/typechain-web3-pr-114/blob/2debfa4278029f30923c5c047ae4fb6c06187a0e/test/simple-storage.test.ts#L6