Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC-7656: Update naming for clarity #502

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Update ERC-7656: Update naming for clarity #502

merged 4 commits into from
Jun 21, 2024

Conversation

sullof
Copy link
Contributor

@sullof sullof commented Jun 20, 2024

After conversations with members of the community, it was clear that the name IERC7656Linked was better than IERC7656Contract but still not ideal. Then, the decision to change it to IERC7656Service, which better aligns with the goal of the ERC, i.e., allowing NFT to own services that extend the capability of the single NFT.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jun 20, 2024 •
edited
Loading

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Update naming for clarity Update ERC-7656: Update naming for clarity Jun 20, 2024
@eip-review-bot eip-review-bot enabled auto-merge (squash) June 20, 2024 22:28
eip-review-bot
eip-review-bot previously approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions GitHub Actions
Copy link

The commit 92d38e9 (as a parent of 9ad71a4) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Jun 20, 2024
@sullof
Copy link
Contributor Author

sullof commented Jun 20, 2024

@abcoathup I am having bot errors that are unrelated to the PR's proposed changes.
Do you know which is the best practice in these cases?

auto-merge was automatically disabled June 21, 2024 04:50

Head branch was pushed to by a user without write access

@eip-review-bot eip-review-bot enabled auto-merge (squash) June 21, 2024 04:51
eip-review-bot
eip-review-bot approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit dd8834d into ethereum:master Jun 21, 2024
9 of 17 checks passed
@github-actions github-actions bot removed the w-ci label Jun 21, 2024
@abcoathup
Copy link
Contributor

@abcoathup I am having bot errors that are unrelated to the PR's proposed changes. Do you know which is the best practice in these cases?

@sullof I assume you resolved them.
For unrelated review-bot issues I suggest reporting in the EIP-editors channel of EthCatHerders Discord.

@sullof
Copy link
Contributor Author

sullof commented Jun 21, 2024

@abcoathup I made another push but obtained the same error. Then, at some moment, the issue got fixed by itself. I have no idea why. Anyway, thanks, I will ask in the Discord server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eip-review-bot eip-review-bot eip-review-bot approved these changes

Assignees
No one assigned
Labels
c-update s-draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sullof @eip-review-bot @abcoathup