Responding to GetChainPacket can send each block 32 times

[TiimJiim]

See below snippet of a trace of sending a large number of blocks to another peer. The routine is sending 32 blocks each time, but it's only decrementing the start block number by one. As well as spamming 32x more data, somewhat unhelpfully for the other peer, the blocks are also sent in reverse order.

=N= [ 22:52:52 | eth | 884 ] Requires 9321 blocks from 9824 to 503
=N= [ 22:52:52 | eth | 884 ] a82ed9e54ef15a5fc5520079f777258ddb80fd68fa111ee991da3212edb08a3a - 92aad04fa2d72fd98770aeae4a64d1bb0b66a20f843b785b7ef6de942bbc95ba
=N= [ 22:52:52 | eth | 884 ] Sending 32 blocks from 535 to 503
=N= [ 22:52:52 | eth | 884 ] 0 41b34287d90738ce2705849a14728c7840bf7b7338425bf21e18701f10eaa8b3
=N= [ 22:52:52 | eth | 884 ] 1 f5f9b19e5da723a2a2a9656616069215b6b27493735d203c7ff40996f55f0e2d
=N= [ 22:52:52 | eth | 884 ] 2 c050e8bed8f33097cd37d3bc1c1b27ab1957e0d2d19010d9ba551e09ed3ae1a1
=N= [ 22:52:52 | eth | 884 ] 3 c615e22741861f82aa5b5722984062e401c1bb015a96e2491af1c229aa46504b
=N= [ 22:52:52 | eth | 884 ] 4 a6a156de51ac3733bc8c2fe12fe386f7faa33a5e7872911b4ba0c56a5e5dfc86
=N= [ 22:52:52 | eth | 884 ] 5 32e87db70e311e753178489df0ef3a2c433742ea50a9d89f3c3f07a2e2dc1253
=N= [ 22:52:52 | eth | 884 ] 6 f31a37ddebdceba977351791d7af52ab81c1a37e7db355d4dafa4687526b723c
=N= [ 22:52:52 | eth | 884 ] 7 d081d5a81bbd985199af8906f345956e3eb379c62a92dccd27a14faf73d1569d
=N= [ 22:52:52 | eth | 884 ] 8 274550b38a3364cf4bac316e9a25041dc6f3891660958926a49ec12afdc486ea
=N= [ 22:52:52 | eth | 884 ] 9 629dc4e028b316310c0a98257f9737512992a33b66126e36b41b200a765e1011
=N= [ 22:52:52 | eth | 884 ] 10 fd30bba5993fd3d09d89a4ecdf55b3d2443a907a85925aa471ecc0f7a59df742
=N= [ 22:52:52 | eth | 884 ] 11 4631f4ba09c57a68b8138818af9992a3d6daf71ebbd6b9a345a41c58b81fc868
=N= [ 22:52:52 | eth | 884 ] 12 192af1eabda8f62d2f65b3796bf9125730d6e0bf6ea57965a02b49d82f23adce
=N= [ 22:52:52 | eth | 884 ] 13 353cf22f09f84e2ed16a6ea21c7d2470c5b4ef941f50c5a5bbe9ec95c8ef5f05
=N= [ 22:52:52 | eth | 884 ] 14 b0b40df3641ac60a73bd854e7872c367e37c6f9b4b2b69d694edfba445cc464c
=N= [ 22:52:52 | eth | 884 ] 15 05ef36003b7bca8e56ecb66f9a9164697f71bef9652049a76b50afcc5159555b
=N= [ 22:52:52 | eth | 884 ] 16 4012730ad2462aefa213bfcd70c76c2936461be080b00efa94722479d6b41f83
=N= [ 22:52:52 | eth | 884 ] 17 8cd1341e8e0770b13220059e12ee634b8a1bcdc74a2656db0b09ed0e746970ee
=N= [ 22:52:52 | eth | 884 ] 18 5d5f9dc2adcf1add3be4d3cbcd7509bfa78ebb26aa50b9f193545da8139d54a9
=N= [ 22:52:52 | eth | 884 ] 19 72e65a3067e6f7186df02aab04766ad9182b55820adf910b50926c521bfe0ac5
=N= [ 22:52:52 | eth | 884 ] 20 4154e5b0fb1cca4e2cf8776682b76343c9b88490695b4cb20a8014bbb24db2ab
=N= [ 22:52:52 | eth | 884 ] 21 b2217897793ee7703afecef354b151e40c2f32a8985e9f5ca0566fd50db6bfc3
=N= [ 22:52:52 | eth | 884 ] 22 78f49a46c133c2d7ead4c6faccb111fd50af42aa39e33f62c76d411f548f1031
=N= [ 22:52:52 | eth | 884 ] 23 df23fcc33e6aa33f6613d24c808a395af8d75026e3dad50733730a62d9699e79
=N= [ 22:52:52 | eth | 884 ] 24 073a1b10a5fd5413476b2981de9f08686a828f7e53a12d4fa319735f67236cc5
=N= [ 22:52:52 | eth | 884 ] 25 2749b23ecaebf8c3768b77be22fcd95e48ff620ed655c9d5bda94ed4cb70f82f
=N= [ 22:52:52 | eth | 884 ] 26 5ca3d4970662f302653f18f020c9c8f0c52ead06890878396f37ede81114f6d8
=N= [ 22:52:52 | eth | 884 ] 27 a234b587b2120a3e3d501c04bebb68644ad0287a3959add1163272b923b44cf4
=N= [ 22:52:52 | eth | 884 ] 28 74fa9ce98733946f7ab0cc7186179620418998ca8b2b520bb616b54bd1bad19a
=N= [ 22:52:52 | eth | 884 ] 29 64e5a12a4150b495297a43dc3f9c9c5844e22cd5b87a0ccb5b9835386895f8c6
=N= [ 22:52:52 | eth | 884 ] 30 a3315ed48a54ad29aa7e7e71a35c5d3b06bd45e698ea9444f47e62a1bd4e1c14
=N= [ 22:52:52 | eth | 884 ] 31 8abd5897bfcf22fab0cedb5cbcf6b0d6e7206fb40371ce0027af571ff5c99327
=N= [ 22:52:52 | eth | 884 ] Parent: 48a4395568a462a1ea4695b4cf0a00f7c114981a4ad200a91382e923e3348103
=N= [ 22:52:52 | eth | 884 ] Requires 9322 blocks from 9824 to 502
=N= [ 22:52:52 | eth | 884 ] a82ed9e54ef15a5fc5520079f777258ddb80fd68fa111ee991da3212edb08a3a - 30630d3fe02f965fff8bd230fe4231f10e2d6097dc4c3055a1d30c6047fb3098
=N= [ 22:52:52 | eth | 884 ] Sending 32 blocks from 534 to 502
=N= [ 22:52:52 | eth | 884 ] 0 f5f9b19e5da723a2a2a9656616069215b6b27493735d203c7ff40996f55f0e2d
=N= [ 22:52:52 | eth | 884 ] 1 c050e8bed8f33097cd37d3bc1c1b27ab1957e0d2d19010d9ba551e09ed3ae1a1
=N= [ 22:52:52 | eth | 884 ] 2 c615e22741861f82aa5b5722984062e401c1bb015a96e2491af1c229aa46504b
=N= [ 22:52:53 | eth | 884 ] 3 a6a156de51ac3733bc8c2fe12fe386f7faa33a5e7872911b4ba0c56a5e5dfc86
=N= [ 22:52:53 | eth | 884 ] 4 32e87db70e311e753178489df0ef3a2c433742ea50a9d89f3c3f07a2e2dc1253
=N= [ 22:52:53 | eth | 884 ] 5 f31a37ddebdceba977351791d7af52ab81c1a37e7db355d4dafa4687526b723c
=N= [ 22:52:53 | eth | 884 ] 6 d081d5a81bbd985199af8906f345956e3eb379c62a92dccd27a14faf73d1569d
=N= [ 22:52:53 | eth | 884 ] 7 274550b38a3364cf4bac316e9a25041dc6f3891660958926a49ec12afdc486ea
=N= [ 22:52:53 | eth | 884 ] 8 629dc4e028b316310c0a98257f9737512992a33b66126e36b41b200a765e1011
=N= [ 22:52:53 | eth | 884 ] 9 fd30bba5993fd3d09d89a4ecdf55b3d2443a907a85925aa471ecc0f7a59df742
=N= [ 22:52:53 | eth | 884 ] 10 4631f4ba09c57a68b8138818af9992a3d6daf71ebbd6b9a345a41c58b81fc868
=N= [ 22:52:53 | eth | 884 ] 11 192af1eabda8f62d2f65b3796bf9125730d6e0bf6ea57965a02b49d82f23adce
=N= [ 22:52:53 | eth | 884 ] 12 353cf22f09f84e2ed16a6ea21c7d2470c5b4ef941f50c5a5bbe9ec95c8ef5f05
=N= [ 22:52:53 | eth | 884 ] 13 b0b40df3641ac60a73bd854e7872c367e37c6f9b4b2b69d694edfba445cc464c
=N= [ 22:52:53 | eth | 884 ] 14 05ef36003b7bca8e56ecb66f9a9164697f71bef9652049a76b50afcc5159555b
=N= [ 22:52:53 | eth | 884 ] 15 4012730ad2462aefa213bfcd70c76c2936461be080b00efa94722479d6b41f83
=N= [ 22:52:53 | eth | 884 ] 16 8cd1341e8e0770b13220059e12ee634b8a1bcdc74a2656db0b09ed0e746970ee
=N= [ 22:52:53 | eth | 884 ] 17 5d5f9dc2adcf1add3be4d3cbcd7509bfa78ebb26aa50b9f193545da8139d54a9
=N= [ 22:52:53 | eth | 884 ] 18 72e65a3067e6f7186df02aab04766ad9182b55820adf910b50926c521bfe0ac5
=N= [ 22:52:53 | eth | 884 ] 19 4154e5b0fb1cca4e2cf8776682b76343c9b88490695b4cb20a8014bbb24db2ab
=N= [ 22:52:53 | eth | 884 ] 20 b2217897793ee7703afecef354b151e40c2f32a8985e9f5ca0566fd50db6bfc3
=N= [ 22:52:53 | eth | 884 ] 21 78f49a46c133c2d7ead4c6faccb111fd50af42aa39e33f62c76d411f548f1031
=N= [ 22:52:53 | eth | 884 ] 22 df23fcc33e6aa33f6613d24c808a395af8d75026e3dad50733730a62d9699e79
=N= [ 22:52:53 | eth | 884 ] 23 073a1b10a5fd5413476b2981de9f08686a828f7e53a12d4fa319735f67236cc5
=N= [ 22:52:53 | eth | 884 ] 24 2749b23ecaebf8c3768b77be22fcd95e48ff620ed655c9d5bda94ed4cb70f82f
=N= [ 22:52:53 | eth | 884 ] 25 5ca3d4970662f302653f18f020c9c8f0c52ead06890878396f37ede81114f6d8
=N= [ 22:52:53 | eth | 884 ] 26 a234b587b2120a3e3d501c04bebb68644ad0287a3959add1163272b923b44cf4
=N= [ 22:52:53 | eth | 884 ] 27 74fa9ce98733946f7ab0cc7186179620418998ca8b2b520bb616b54bd1bad19a
=N= [ 22:52:53 | eth | 884 ] 28 64e5a12a4150b495297a43dc3f9c9c5844e22cd5b87a0ccb5b9835386895f8c6
=N= [ 22:52:53 | eth | 884 ] 29 a3315ed48a54ad29aa7e7e71a35c5d3b06bd45e698ea9444f47e62a1bd4e1c14
=N= [ 22:52:53 | eth | 884 ] 30 8abd5897bfcf22fab0cedb5cbcf6b0d6e7206fb40371ce0027af571ff5c99327
=N= [ 22:52:53 | eth | 884 ] 31 48a4395568a462a1ea4695b4cf0a00f7c114981a4ad200a91382e923e3348103
=N= [ 22:52:53 | eth | 884 ] Parent: 30e25afbb942e5bd41b39df4fff90ead6230bf0551e5d45265257873d0ce139a

[gavofyork]

fixed.