Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks are broken #131

Closed
belijzajac opened this issue Feb 12, 2023 · 0 comments · Fixed by #132
Closed

Benchmarks are broken #131

belijzajac opened this issue Feb 12, 2023 · 0 comments · Fixed by #132

Comments

@belijzajac
Copy link

belijzajac commented Feb 12, 2023

Benchmarks for other bindings are likely broken as well. It would be great if they were included in CI.

┌─[tautvydas][kagamin][±][main ✓][~/Git/c-kzg-4844/bindings/rust]
└─▪ cargo bench
   Compiling c-kzg v0.1.0 (/mnt/home/Git/c-kzg-4844/bindings/rust)
error[E0308]: mismatched types
   --> benches/kzg_benches.rs:56:61
    |
56  |                         .verify_aggregate_kzg_proof(&blobs, &kzg_commitments, &kzg_settings)
    |                          --------------------------         ^^^^^^^^^^^^^^^^ expected slice, found struct `Vec`
    |                          |
    |                          arguments to this function are incorrect
    |
    = note: expected reference `&[Bytes48]`
               found reference `&Vec<c_kzg::KZGCommitment>`
note: associated function defined here
   --> /mnt/home/Git/c-kzg-4844/bindings/rust/src/lib.rs:205:12
    |
205 |     pub fn verify_aggregate_kzg_proof(
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0308`.
error: could not compile `c-kzg` due to previous error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant