Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup node bindings #149

Closed
asn-d6 opened this issue Feb 20, 2023 · 2 comments
Closed

Cleanup node bindings #149

asn-d6 opened this issue Feb 20, 2023 · 2 comments

Comments

@asn-d6
Copy link
Contributor

asn-d6 commented Feb 20, 2023

The node bindings (https://github.com/ethereum/c-kzg-4844/tree/main/bindings/node.js) seem to contain quite a few files and it makes it hard to review the actual code. Can we tidy them up somehow?

/cc @dgcoffman
@dgcoffman
Copy link
Contributor

Each of those files serves a purpose. What tidying do you imagine? Happy to review a PR.

@asn-d6 asn-d6 mentioned this issue Feb 24, 2023
Closed
@matthewkeil matthewkeil mentioned this issue Feb 27, 2023
Closed
@asn-d6
Copy link
Contributor Author

asn-d6 commented Feb 28, 2023

Will be handled as part of #153

@asn-d6 asn-d6 closed this as completed Feb 28, 2023
@matthewkeil matthewkeil mentioned this issue Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgcoffman @asn-d6