Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Rust bindings on crates.io #346

Closed
DaniPopes opened this issue Aug 18, 2023 · 3 comments
Closed

Release Rust bindings on crates.io #346

DaniPopes opened this issue Aug 18, 2023 · 3 comments

Comments

@DaniPopes
Copy link
Contributor

We'd like to use the c-kzg bindings in revm. Currently, we would have to import them as a git dependency on this repository, but then we will not be able to release the revm crates on crates.io ourselves, since git dependencies are not allowed: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-git-repositories.

@rakita
Copy link
Contributor

rakita commented Sep 2, 2023

Published crate with newest main to have something there and to unblock us on revm side: https://crates.io/crates/c-kzg
Published from this branch: https://github.com/rakita/c-kzg-4844/tree/publish

Perfectly okay to transfer ownership to the team in the future.

@asn-d6
Copy link
Contributor

asn-d6 commented Sep 12, 2023

My understanding is that if we want to support both minimal and mainnet config, we would need to publish two crates right now. Is this correct?

In this case, #352 would be a nice improvement, since it would allow us to publish a single crate that can support any config.

@asn-d6
Copy link
Contributor

asn-d6 commented Feb 23, 2024

Closing stale tickets. Feel free to reopen if needed.

@asn-d6 asn-d6 closed this as completed Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants