Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make casper.py data structure agnostic #52

Closed
naterush opened this issue Oct 14, 2017 · 1 comment
Closed

Make casper.py data structure agnostic #52

naterush opened this issue Oct 14, 2017 · 1 comment

Comments

@naterush
Copy link
Collaborator

Issue

Currently, casper.py must change depending on the data structures on which consensus is being formed. This makes it harder for binary + blockchain + possible re-write proof stuff to live in the same branch as it will lead to a fair bit of code duplication.

This is one of the considerations for issue #26

Implementation

Change casper.py to be data structure agnostic by having Casper deal mostly with message propagation and generation. Then, the resulting view (and validator set?), as well as the most recent messages propagated, can be passed into some plot tool, which can display them in the regular view graph.

Without this refactor, the plot tool will have to change in any case - but this reduces the amount of code that has to change and/or duplicated for multiple data structures to exist together (and this likely makes it easier to change).

@naterush naterush mentioned this issue Oct 17, 2017
@naterush
Copy link
Collaborator Author

#65 <- this issue supersedes. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant