Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression test for #1037 #1040

Closed
JustinDrake opened this issue May 3, 2019 · 2 comments
Closed

Regression test for #1037 #1040

JustinDrake opened this issue May 3, 2019 · 2 comments
Assignees
@protolambda
Labels
scope:CI/tests/pyspec

Comments

@JustinDrake
Copy link
Collaborator

#1037 was merged in quickly to make it for 0.6.1. A regression test would be useful.
@djrtwo
Copy link
Contributor

djrtwo commented May 3, 2019 •
edited
Loading

The code path is known to be executed so that is good but need a test in which attestations vote on incorrect head but correct justified source and proposer still gets rewarded

@JustinDrake
Copy link
Collaborator Author

Closing for staleness, and in favour of fuzz testing to catch these edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@protolambda protolambda

Labels
scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JustinDrake @djrtwo @protolambda