Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the BLS fast_aggregate_verify tests are incorrect in v0.10.1 #1597

Closed
benjaminion opened this issue Jan 25, 2020 · 1 comment
Closed

Comments

@benjaminion
Copy link
Contributor

For example, compare fast_aggregate_verify_62bca7cd61880e26/data.yaml:

input:
  pubkeys: ['0xa491d1b0ecd9bb917989f0e74f0dea0422eac4a873e5e2644f368dffb9a6e20fd6e10c1b77654d067c0618f6e5a7f79a']
  message: '0x0000000000000000000000000000000000000000000000000000000000000000'
  signature: '0xb2a0bd8e837fc2a1b28ee5bcf2cddea05f0f341b375e51de9d9ee6d977c2813a5c5583c19d4e7db8d245eebd4e502163076330c988c91493a61b97504d1af85fdc167277a1664d2a43af239f76f176b215e0ee81dc42f1c011dc02d8b0a31e32'
output: false

with fast_aggregate_verify_009950361f371349/data.yaml:

input:
  pubkeys: ['0xa491d1b0ecd9bb917989f0e74f0dea0422eac4a873e5e2644f368dffb9a6e20fd6e10c1b77654d067c0618f6e5a7f79a']
  message: '0x0000000000000000000000000000000000000000000000000000000000000000'
  signature: '0xb2a0bd8e837fc2a1b28ee5bcf2cddea05f0f341b375e51de9d9ee6d977c2813a5c5583c19d4e7db8d245eebd4e502163076330c988c91493a61b97504d1af85fdc167277a1664d2a43af239f76f176b215e0ee81dc42f1c011dc02d8b0a31e32'
output: true

Spot the difference? Clue: same input data, different expected result 😂

PR incoming to fix the generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants