-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalized Root In Genesis Is Not Clarified #1848
Comments
The reason is that the genesis state contains a |
While having a This would only become clear when each peer is unable to process the other peer's blocks, also intuitively it would be easy to mistake that the genesis state's finalized root is the genesis block. Maybe this can be clarified in the spec instead that at genesis checkpoint roots are |
We're looking to restart the Topaz network with v0.12 changes, could we get some clarity on which is the appropriate solution? The majority of the clients in Witti understood that the finalized checkpoint root was the genesis block root, but we switched to |
Considering 0x00 is used in a number of locations and that clients are currently conformant to 0x00, I'd prefer to keep it here as a special case. I'll make note in the spec today |
Also, now that I'm looking at it "state.finalized_checkpoint.root for the state corresponding to the head block" should in fact give you the genesis root as will still add a clarifying comment |
https://github.com/ethereum/eth2.0-specs/blob/dev/specs/phase0/p2p-interface.md#status
Currently in the networking spec:
This came up in witti, as we were expecting the genesis block root as the finalized root in status messages, but lighthouse instead expected a
zero_hash
. Is there any reason thegenesis_block_root
cannot be considered as the root in the finalized checkpoint ?The text was updated successfully, but these errors were encountered: