Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altair test-vectors at fork transition #2662

Closed
potuz opened this issue Oct 11, 2021 · 0 comments · Fixed by #2664
Closed

Altair test-vectors at fork transition #2662

potuz opened this issue Oct 11, 2021 · 0 comments · Fixed by #2664
Assignees

Comments

@potuz
Copy link
Contributor

potuz commented Oct 11, 2021

There are a few edge case situations that may happen at the Altair fork and are currently under-tested:

  • A validator is slashed in phase0 and is active but slashing at the fork and thus leaking. It may or not be a member of a sync committee, we need to check the right penalties.
  • A validator started an exit in phase0 and is put in a queue, check these queues, either active or leaking at the fork.
  • Quadratic leaking in case of network not finalizing at the fork.
  • An activator deposited in phase0 and is in the queue at the fork.

Many of these tests are done already at Altair, but implementations may differ in the way they compute rewards/penalties if a slashing event for example happened before the fork. Thus this could eventually lead to a consensus failure with the cost of only slashing a single validator.

This is follow up from discussions in
https://discord.com/channels/595666850260713488/598292067260825641/897248922706255893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants