Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying proposer boost to ancestors #2757

Closed
realbigsean opened this issue Dec 1, 2021 · 0 comments · Fixed by #2760
Closed

Applying proposer boost to ancestors #2757

realbigsean opened this issue Dec 1, 2021 · 0 comments · Fixed by #2760

Comments

@realbigsean
Copy link
Contributor

It looks like the proposer score boost is not applied to ancestors of the boosted block, even during the boosted block's slot. Is this the correct behavior?

This is highlighted by the test scenario: shorter_chain_but_heavier_weight

In that scenario, during slot 3, there is a proposer-boosted block from slot three, as well as a late-arriving block from slot 1. The test expects the block from slot 1 to be set as head, even when they are tied in attestation weight (at zero). I'd expect the get_head method to incorporate the proposer boost and set block 3 as head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants