-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reference test for invalid deposit with unparsable public key #2986
Comments
It's probably also worth testing these with a single deposit and with the full 16 deposits. It can be useful to use batch signature verification since deposit signatures are usually valid but if any are invalid you have to go find the right one (which can be complicated by things like unparseable public keys). One vs multiple deposits did wind up making a difference in Teku. |
It probably makes sense to add other cases: Also the sample for the case (3): |
Related spec PR: #2987 |
There doesn't appear to be any reference test that uses an unparsable public key in deposits. There's tests for invalid signatures but there are a few cases with public keys worth testing:
0x000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
0xc00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
The text was updated successfully, but these errors were encountered: