Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize test case naming #3118

Closed
hwwhww opened this issue Nov 18, 2022 · 2 comments
Closed

Standardize test case naming #3118

hwwhww opened this issue Nov 18, 2022 · 2 comments
Labels
scope:CI/tests/pyspec

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Nov 18, 2022

Issue

We currently have test case names with test_invalid_...,test_fail_..., test_..._invalid, test_valid_..., test_..._valid... .etc. It would be nice if they were in the same format.

Proposal

  • Using prefix test_invalid_<DESCRIPTION> for the test case that is expected to fail, i.e., post-state does not exist.
  • Using simple test_<DESCRIPTION> for the test case that is expected to succeed, i.e., post-state exists.
@djrtwo
Copy link
Contributor

djrtwo commented Nov 21, 2022

I like it!

@hwwhww hwwhww mentioned this issue Nov 30, 2022
Merged
@hwwhww
Copy link
Contributor Author

hwwhww commented Jan 3, 2023

closing via #3143

@hwwhww hwwhww closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djrtwo @hwwhww