Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more single_merkle_proof tests #3539

Closed
Tracked by #3458
hwwhww opened this issue Nov 2, 2023 · 4 comments
Closed
Tracked by #3458

Add more single_merkle_proof tests #3539

hwwhww opened this issue Nov 2, 2023 · 4 comments
Labels
scope:CI/tests/pyspec

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Nov 2, 2023

Suggested by @potuz, having randomized BeaconBlockBody would be helpful to detect the edge cases.
@ppopth
Copy link
Member

ppopth commented Nov 6, 2023

Like fuzz testing?

@potuz
Copy link
Contributor

potuz commented Nov 6, 2023

The static spectests have some testvectors that are randomly generated. In this particular case, our implementation had a bug that could have been caught early if the testvector had some slashings, the test vector had a full block, but the block didn't have any slashings in it.

@hwwhww
Copy link
Contributor Author

hwwhww commented Nov 7, 2023

@ppopth

I'm thinking about just creating ~10 test cases with different RNG seeds and utilizing the existing random_block_deneb helper.

@hwwhww hwwhww mentioned this issue Nov 21, 2023
Closed
7 tasks
@hwwhww hwwhww mentioned this issue Nov 30, 2023
Merged
@hwwhww
Copy link
Contributor Author

hwwhww commented Dec 1, 2023

closing via #3555

@hwwhww hwwhww closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ppopth @hwwhww @potuz