Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refactoring upgrade_to_electra #3698

Closed
ralexstokes opened this issue Apr 18, 2024 · 0 comments · Fixed by #3711
Closed

Consider refactoring upgrade_to_electra #3698

ralexstokes opened this issue Apr 18, 2024 · 0 comments · Fixed by #3711
Labels

Comments

@ralexstokes
Copy link
Member

exit_balance_to_consume=get_activation_exit_churn_limit(pre),

The exit_balance_to_consume and the consolidation_balance_to_consume in upgrade_to_electra both currently take a deneb state but as written they are electra functions so expect an electra state.

The functions currently do not touch any electra data and so there is no test/build issue, but this is a bit confusing for implementation.

We could initialize these fields as 0 and then compute them on the next line using the post variable (that has the correct type).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant