Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove/change xor(seed, epoch) in shuffling #550

Closed
djrtwo opened this issue Feb 1, 2019 · 0 comments
Closed

remove/change xor(seed, epoch) in shuffling #550

djrtwo opened this issue Feb 1, 2019 · 0 comments

Comments

@djrtwo
Copy link
Contributor

djrtwo commented Feb 1, 2019

Issue

get_shuffling xor's the epoch into the seed on the fly. This obfuscates the actual seed being used in shuffle. The reason epoch is in this seed is to enforce a new seed at a reshuffling even in the event that entire epochs of slots have been skipped (i.e. in the unlikely event that randao mix stayed the same and active index root stayed the same).

Proposed implementation

add epoch into the hash calculation in generate_seed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant