Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor AttestationData cleanup #698

Closed
JustinDrake opened this issue Feb 27, 2019 · 1 comment
Closed

Minor AttestationData cleanup #698

JustinDrake opened this issue Feb 27, 2019 · 1 comment
Labels
general:enhancement New feature or request general:presentation Presentation (as opposed to content) general:proofread spelling, grammar, accuracy

Comments

@JustinDrake
Copy link
Collaborator

JustinDrake commented Feb 27, 2019

Suggested refactor of AttestationData for readability:

{
    # LMD GHOST vote
    'slot': Slot,
    'beacon_block_root': Hash,

    # FFG vote
    'source_epoch': Epoch,
    'source_root': Hash,
    'target_root': Hash,

    # Crosslink vote
    'shard': Shard,
    'previous_crosslink': Crosslink,
    'crosslink_data_root': Hash,
}
  • Reorder fields and semantically batch by vote type
  • Rename justified_epoch to source_epoch and justified_block_root to source_root (more to the point and shorter).
  • Rename epoch_boundary_root to target_root (more to the point and shorter)
  • Rename latest_crosslink to previous_crosslink (more consistent/correct name)
@hwwhww hwwhww added general:enhancement New feature or request general:presentation Presentation (as opposed to content) general:proofread spelling, grammar, accuracy labels Feb 28, 2019
@JustinDrake
Copy link
Collaborator Author

Done in #756.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general:enhancement New feature or request general:presentation Presentation (as opposed to content) general:proofread spelling, grammar, accuracy
Projects
None yet
Development

No branches or pull requests

2 participants