Windows - libethash - multiple concurrent miners crash application

[ghost]

Attempting to run multiple separate miners in Windows (7/8/10) crashes out. After initial miner started any subsequent miner will fail when attempting to open the DAG. This isn't happening in Linux.

The issue is that the ethash_fopen function in io_win32.c calls fopen_s which opens files exclusively in Windows environment. I suggest we could change:

FILE* ethash_fopen(char const* file_name, char const* mode)
{
	FILE* f;
	return fopen_s(&f, file_name, mode) == 0 ? f : NULL;
}

to

FILE* ethash_fopen(char const* file_name, char const* mode)
{
	return _fsopen( file_name, mode, _SH_DENYNO );
}

I've changed and tested this locally and have had no issues so far with it.

Let me know if you'd like my to open a pull request with the change in place for review. I'm new to contributing to github projects so I'm not up to speed on good etiquette...

[chriseth]

Are you using the cpp-ethereum miner or the genoil miner? It might be better to just make that change in the genoil miner, because it is better maintained.

[ghost]

Hello, I actually use the go-ethereum miner which still uses the libethash library. I was also going to raise an issue with them so they can change their code as well. I'm not currently sure if they track libethash changes or have forked it completely. If you think it's better for me to raise the issue there them I'm happy to do that. Kev.

…

On 05/01/2017 15:12, chriseth wrote: Are you using the cpp-ethereum miner or the genoil miner? It might be better to just make that change in the genoil miner, because it is better maintained. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3484 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AXleeF7JIYr07WOuqyXAggItmiNnDDyHks5rPQhngaJpZM4LbnrD>.

[chriseth]

Ah, then it might make sense reporting this to http://github.com/ethereum/ethash - but please also keep this one here open as a reminder for us.