Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3 tooling has broken type-checking #227

Open
njgheorghita opened this issue Nov 24, 2020 · 0 comments
Open

Web3 tooling has broken type-checking #227

njgheorghita opened this issue Nov 24, 2020 · 0 comments

Comments

@njgheorghita
Copy link
Contributor

What was wrong?

The Discovery5Module in the web3 tooling is not being type-checked correctly. The mypy check passes successfully when the attached Methods are missing a type and when the declared type is incorrect.

Code that produced the error

https://github.com/ethereum/ddht/blob/master/ddht/tools/web3.py#L286-L355

Expected Result

Mypy runs should fail when attached methods are missing a type and if the declared type is incorrect.

How can it be fixed?

From #224 (comment)

My guess is that web3.py might be leaking Any which is typically where this type of deficiency shows up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant