Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The text of autolinks should not be searched for regular expression matches #91

Open
SamWilsn opened this issue Mar 20, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers ready to implement Feature has reached rough consensus among editors and is ready to be implemented

Comments

@SamWilsn
Copy link
Collaborator

For example:

Full specification: <https://github.com/ethereum/consensus-specs/blob/5d80b1954a4b7a121aa36143d50b366727b66cbc/specs/_features/eip7002/beacon-chain.md>

Generates the following diagnostic:

error[markdown-re-eip-dash]: proposals must be referenced with the form `EIP-N` (not `EIPN` or `EIP N`)
   --> EIPS/eip-7002.md
    |
535 | Full specification: <https://github.com/ethereum/consensus-specs/blob/5d80b1954a4b7a121aa36143d50b366727b66cbc/specs/_features/eip7002/beacon-chain.md> 
    |
    = info: the pattern in question: `(?i)eip[\s]*[0-9]+`
    = help: see https://ethereum.github.io/eipw/markdown-re-eip-dash/

Reported by @lightclient in this run on this PR.

@SamWilsn SamWilsn added bug Something isn't working good first issue Good for newcomers ready to implement Feature has reached rough consensus among editors and is ready to be implemented labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers ready to implement Feature has reached rough consensus among editors and is ready to be implemented
Projects
None yet
Development

No branches or pull requests

1 participant