This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
Ignore calls to startAuction for auctions already running. Fixes #54 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
approved these changes
Mar 26, 2017
| function startAuction(bytes32 _hash) registryOpen() { | ||
| var mode = state(_hash); | ||
| if(mode == Mode.Auction) return; | ||
| if(mode != Mode.Open) throw; |
There was a problem hiding this comment.
Since this is not payable... why throw instead of return?
There was a problem hiding this comment.
Because it's an error to try and open an auction that can't be opened (at least in my mind), and throwing reflects this. If this is being called by startAuctions, it also ensures that the call as a whole fails.
Arachnid
force-pushed
the
idempotentopen
branch
from
02f4431
to
2244958
Compare
ericobi
pushed a commit
to CodeXChainOfficial/ens
that referenced
this pull request
Aug 23, 2023
Fix small typo in docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.