New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Parsimonious dependency to >=0.9.0,<0.10 #201
Conversation
6ac2db4
to
50a6453
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm... we should keep a lint
command for locally linting though. I left a comment on that. Add newsfragment and we are gtg 👍🏼
Just curious: Why is the Would it make sense to add comments in the code about why the restrictions are how they are? Also, this doesn't make sense to me:
Wouldn't |
On a side-note: I think Version pinning means setting an exact version (pin-point the version). What I see in the PR are version constraints, but no version pinning. Which is good. A library should typically not pin versions. |
@MT-Cash:
Parsimonious changed it's
Typo. Parsimonious 0.9.0 works. |
4adb3b0
to
7fe7468
Compare
What was wrong?
Parsimonious<0.9 was incompatible with Python 3.11.
Closes #195
How was it fixed?
Added smoke tests for all supported Python versions for both lint (dev dependencies) and wheel tests.
To-Do
Cute Animal Picture