Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Parsimonious dependency to >=0.9.0,<0.10 #201

Merged
merged 5 commits into from Mar 16, 2023

Conversation

kclowes
Copy link
Contributor

@kclowes kclowes commented Mar 15, 2023

What was wrong?

Parsimonious<0.9 was incompatible with Python 3.11.

Closes #195

How was it fixed?

Added smoke tests for all supported Python versions for both lint (dev dependencies) and wheel tests.

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

@kclowes kclowes marked this pull request as ready for review March 16, 2023 17:22
@kclowes kclowes requested review from fselmo and pacrob March 16, 2023 17:24
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm... we should keep a lint command for locally linting though. I left a comment on that. Add newsfragment and we are gtg 👍🏼

tox.ini Show resolved Hide resolved
@martin-thoma
Copy link

Just curious: Why is the <0.10 restriction there?

Would it make sense to add comments in the code about why the restrictions are how they are?

Also, this doesn't make sense to me:

Parsimonious<=0.9 was incompatible with Python 3.11.
[we want to ensure it works with Python 3.11] =>
Pin parsimonious to >=0.9.0

Wouldn't Parsimonious==0.9 not work as well, hence it should be parsimonious to > 0.9.0

@martin-thoma
Copy link

On a side-note: I think Version pinning means setting an exact version (pin-point the version). What I see in the PR are version constraints, but no version pinning. Which is good. A library should typically not pin versions.

@kclowes
Copy link
Contributor Author

kclowes commented Mar 16, 2023

@MT-Cash:

Why is the <0.10 restriction there?

Parsimonious changed it's NodeVisitor API in 0.10.0: https://app.circleci.com/pipelines/github/ethereum/eth-abi/186/workflows/ec7abca3-522b-4760-b0e8-ec4cb722f3f7/jobs/3168

Parsimonious<=0.9 was incompatible with Python 3.11.

Typo. Parsimonious 0.9.0 works.

@kclowes kclowes changed the title Pin parsimonious to >=0.9.0,<0.10 Update Parsimonious dependency to >=0.9.0,<0.10 Mar 16, 2023
@kclowes kclowes merged commit 30442f1 into ethereum:master Mar 16, 2023
1 check passed
@kclowes kclowes deleted the pin-parsimonious branch March 16, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants