Fix requirements docs txt #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
fix-requirements-docs-txt
branch
4 times, most recently
from
cd83edd
to
0043680
Compare
fselmo
reviewed
Apr 10, 2023
newsfragments/204.internal.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Moved requirements-docs.txt info info .readthedocs.yml | |||
There was a problem hiding this comment.
Suggested change
| Moved requirements-docs.txt info info .readthedocs.yml | |
| Moved requirements-docs.txt info into .readthedocs.yml |
There was a problem hiding this comment.
thanks for catching!
fselmo
approved these changes
Apr 10, 2023
pacrob
force-pushed
the
fix-requirements-docs-txt
branch
from
0043680
to
1c954a3
Compare
pacrob
force-pushed
the
fix-requirements-docs-txt
branch
from
1c954a3
to
7381e5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
readthedocs was building with the wrong versions, related to ethereum/ethereum-python-project-template#40
How was it fixed?
Discovered a
.readthedocs.ymlformat that rendersrequirements-docs.txtunnecessary.Removed
requirements-docs.txt, moved it all to.readthedocs.yml.Also, prefer
.ymlto.yaml.To-Do
Cute Animal Picture