Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade parsimonious to 0.10 #231

Merged
merged 3 commits into from Mar 27, 2024
Merged

Conversation

jorenham
Copy link
Contributor

@jorenham jorenham commented Mar 5, 2024

What was wrong?

The parsimonious dep was pinned to an outdated version.

The 0.10.0 release includes bugfixes and performance improvements, see https://github.com/erikrose/parsimonious?tab=readme-ov-file#version-history.

The breaking change that's mentioned shouldn't affect the grammar that's used here, as it used spaces where relevant.

How was it fixed?

Sheer willpower.

Todo:

  • Clean up commit history

  • Add or update documentation related to these changes

  • Add entry to the release notes

Cute Animal Picture

The shoebill

The shoebill (Balaeniceps rex), also known as the whalebill, whale-headed stork, and shoe-billed stork is a large long-legged wading bird.

[Wikipedia - Shoebill]

@jorenham
Copy link
Contributor Author

I noticed that the newsfragments directory is empty. Should I create a newsfragment there nonetheless, or edit the release notes directly, or ...?

@pacrob
Copy link
Contributor

pacrob commented Mar 26, 2024

I noticed that the newsfragments directory is empty. Should I create a newsfragment there nonetheless, or edit the release notes directly, or ...?

There's usage info in the README within the newsfragments directory. For this PR, I'd use the filename 231.internal.rst. The files are then collected and processed into release notes at the next release.

@pacrob
Copy link
Contributor

pacrob commented Mar 27, 2024

looks good, thanks @jorenham !

@pacrob pacrob merged commit 20bf7a2 into ethereum:main Mar 27, 2024
16 checks passed
@jorenham jorenham deleted the parsimonious-0.10 branch March 27, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants