Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update documentation for sign_transaction based on recent changes #126

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

fselmo
Copy link
Contributor

@fselmo fselmo commented Sep 16, 2021

What was wrong?

Update the docs on sign_transaction to reflect recent changes

How was it fixed?

docs were updated

To-Do

  • Clean up commit history

Cute Animal Picture

IMG_20210619_201536

@fselmo fselmo force-pushed the update-docs-for-sign-transaction branch from 4e7d5c8 to cf9de62 Compare September 16, 2021 22:30
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

newsfragments/126.doc.rst Outdated Show resolved Hide resolved
@fselmo fselmo force-pushed the update-docs-for-sign-transaction branch from cf9de62 to 7ff621c Compare September 16, 2021 22:33
@fselmo fselmo merged commit 99d2ac5 into ethereum:master Sep 16, 2021
@fselmo fselmo deleted the update-docs-for-sign-transaction branch March 15, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants