Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc dependencies #156

Merged
merged 3 commits into from Apr 7, 2022
Merged

Fix doc dependencies #156

merged 3 commits into from Apr 7, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Apr 7, 2022

What was wrong?

Doc builds started failing.

How was it fixed?

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

@kclowes kclowes changed the title [WIP] Fix doctest dependencies Fix doc dependencies Apr 7, 2022
Copy link
Collaborator

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kclowes kclowes force-pushed the fix-docbuild branch 2 times, most recently from e8533b8 to 52f1b00 Compare April 7, 2022 22:20
@kclowes kclowes merged commit 1355446 into ethereum:master Apr 7, 2022
@kclowes kclowes deleted the fix-docbuild branch April 7, 2022 22:35
"sphinx_rtd_theme>=0.1.9,<1",
"towncrier>=19.2.0, <20",
"towncrier==18.5.0", # towncrier doesn't follow semver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, say it aint so! Did towncrier confirmed this in their docs somewhere?

Is there some interdependency that fails on more recent versions when towncrier is more recent? Just curious which API is changing that we are using.

I also got bitten by this issue in working on eth-portal. (I haven't run into a towncrier issue yet, but I also haven't generated any release notes) See: ethereum/eth-portal@6ad0733

I suppose all these doc dependencies should get pinned here, too, then:
https://github.com/ethereum/ethereum-python-project-template/blob/b88fcf3c0b70ea7e4bd0fbc89b546a37877ce50e/setup.py#L20-L23
(whether the version you picked here, or the path I took)

(Plus, the commentary about why, and when the dependencies can change again.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did towncrier confirmed this in their docs somewhere?

No, but if you look at their release history on pypi you can see it used to be year.month.something and now I'm not sure what the pattern is.

The problem for us is that more recent versions than 18.5.0 were adding a double header on our releases. I suspect because it wasn't respecting the custom format that we had.

I suppose all these doc dependencies should get pinned here, too

good thought!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem for us is that more recent versions than 18.5.0 were adding a double header on our releases. I suspect because it wasn't respecting the custom format that we had.

Oh interesting, that's what it was!

Copy link
Contributor

@carver carver May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants