Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tox.ini lint section and mypy issue #166

Merged
merged 3 commits into from
May 26, 2022
Merged

Conversation

Elnaril
Copy link
Contributor

@Elnaril Elnaril commented May 26, 2022

What was wrong?

tox was not running the lint section, as describe here
Once fixed, a lint error was raised.

How was it fixed?

The header of the lint section in tox.ini was fixed.

The # type: ignore that was causing the mypy error was not needed anymore, since the underlying issue was fixed.

To-Do

Cute Animal Picture

put a cute animal picture link inside the parentheses

@Elnaril
Copy link
Contributor Author

Elnaril commented May 26, 2022

CI is not launched automatically ?
Anyway, this PR is ready for review :)

@Elnaril
Copy link
Contributor Author

Elnaril commented May 26, 2022

BTW, do I need to add a release note ?

@kclowes
Copy link
Collaborator

kclowes commented May 26, 2022

CI is not launched automatically ?

There is some permissions thing where it isn't launched automatically for (first time?) third party contributors.

BTW, do I need to add a release note ?

I'll add a release note to trigger the build. Thank you!

Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up on this @Elnaril ... I factored out some of this to keep a lint tox command to not break our Makefile.

@kclowes this looks good to me... can you take a last peek?

@Elnaril
Copy link
Contributor Author

Elnaril commented May 26, 2022

Thanks for picking up on this @Elnaril

My pleasure! :)

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @Elnaril and @fselmo!

@kclowes kclowes merged commit bf90687 into ethereum:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants