Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update circleci img, Remove Sphinx warning #194

Merged
merged 3 commits into from Aug 17, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Aug 17, 2022

What was wrong?

CircleCI has been warning us about using deprecated images, and Sphinx autogenerates a file that we haven't been correctly ignoring.

How was it fixed?

  • moved circleci images from circleci -> cimg
  • I tried to exclude docs/eth_account.hdaccount.rst from being generated, but couldn't figure that out, so I added the auto-generated file to git and added the :orphan: tag at the top. This fixes the warning that was being issued on the make docs command indicating that docs/eth_account.hdaccount.rst wasn't being included in any toctree.

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

@kclowes kclowes marked this pull request as ready for review August 17, 2022 20:04
@kclowes kclowes requested a review from pacrob August 17, 2022 20:28
Copy link
Collaborator

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kclowes kclowes merged commit 6991ea3 into ethereum:master Aug 17, 2022
@kclowes kclowes deleted the update-circleci-img branch August 17, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants