Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use f-strings in place of old % and .format strings #245

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

pacrob
Copy link
Collaborator

@pacrob pacrob commented Nov 30, 2023

What was wrong?

Old % and .format strings still in use.

How was it fixed?

changed to modern f-strings

Todo:

  • Clean up commit history

  • Add or update documentation related to these changes

  • Add entry to the release notes

Cute Animal Picture

image

@pacrob pacrob force-pushed the use-f-strings branch 2 times, most recently from 6fa50b2 to a747c2b Compare November 30, 2023 23:25
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Animal pictures have been on point lately!

@pacrob pacrob merged commit b488362 into ethereum:master Dec 1, 2023
23 checks passed
@pacrob pacrob deleted the use-f-strings branch December 1, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants