Cancun updates #253
Merged
Cancun updates #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
added a commit
to fselmo/eth-account
that referenced
this pull request
Mar 19, 2024
fselmo
force-pushed
the
cancun-updates
branch
2 times, most recently
from
9c37511
to
8f86c60
Compare
kclowes
approved these changes
Mar 22, 2024
fselmo
force-pushed
the
cancun-updates
branch
4 times, most recently
from
bacefd3
to
438c641
Compare
|
New API for generating commitments and proofs from blobs added with pydantic models for validation. RLP serialization and deserialization with the edit: more tests added |
- Re-organize typed transactions as a directory with each `_TypedTransactionImplementation` as its own file. - Add support for `BlobTransaction` (type = 3). - Add relevant tests. Also: - Normalize transaction dict for ``TypedTransaction.as_dict()`` so that lists or tuples are converted to tuples for consistency and ease of comparison.
- When a blob transaction is signed, it needs to contain the blob information along with commitments and proofs for the consensus layer. We need to be able to serialize and deserialize this information. - Use different serializers for execution layer style `TransactionPayloadBody` blob transactions and for `PooledTransaction` blob transactions.
- Add some testing around blob transaction `blobVersionedHashes` validation when present in tx dict compared to the computed values from blobs. - Add testing around the computing of commitment, proofs, and versioned hashes. - Add testing around the blob count limits for a blob carrying transaction.
pacrob
approved these changes
Mar 28, 2024
This was referenced Apr 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
3blob transactionsaccessListorblobVersionedHasheswithin a dict all normalize to tuples for consistency and ease of comparison.Todo:
PooledTransactionAPICute Animal Picture