Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open up Pydantic requirement #271

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Apr 8, 2024

What was wrong?

We can open up the Pydantic requirement a little, so we should.

Inspired by #270, but doesn't fix it.

How was it fixed?

Opened up the range.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes force-pushed the open-up-pydantic-requirement branch from 83d3fbf to 7309598 Compare April 8, 2024 19:17
@fselmo
Copy link
Contributor

fselmo commented Apr 8, 2024

This should be merged into v0.12.x, correct? I suppose both that and main will need a PR.

@kclowes
Copy link
Collaborator Author

kclowes commented Apr 8, 2024

oop, yep. Nice catch

@kclowes kclowes changed the base branch from main to 0.12.x April 8, 2024 19:55
@kclowes kclowes changed the base branch from 0.12.x to main April 8, 2024 19:55
@kclowes
Copy link
Collaborator Author

kclowes commented Apr 8, 2024

On second thought, I'll open up a new PR against v0.12.x.

@kclowes kclowes marked this pull request as ready for review April 8, 2024 20:02
@kclowes kclowes requested review from fselmo, reedsa and pacrob April 8, 2024 20:03
Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@kclowes kclowes merged commit 34ec1be into ethereum:main Apr 8, 2024
20 checks passed
@kclowes kclowes deleted the open-up-pydantic-requirement branch April 8, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants