Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black #41

Merged
merged 2 commits into from Jul 6, 2022
Merged

Add black #41

merged 2 commits into from Jul 6, 2022

Conversation

kclowes
Copy link
Contributor

@kclowes kclowes commented Jul 1, 2022

This is branched off of #40 so only the last commit needs to be reviewed here, and this should be merged after #40

What was wrong?

Adding black to the repo. This repo is small enough that I felt okay doing it all in one fell swoop.

How was it fixed?

Added the black dependency, and added it to the lint commands.

To-Do

  • Clean up commit history
  • Add entry to the release notes

  • Add .git-blame-ignore-revs file with commit number once it's finalized

Cute Animal Picture

@kclowes kclowes force-pushed the add-black branch 5 times, most recently from 366f438 to 93512fb Compare July 1, 2022 18:17
@kclowes kclowes marked this pull request as ready for review July 1, 2022 18:21
@kclowes kclowes requested review from fselmo and pacrob July 1, 2022 18:21
tox.ini Show resolved Hide resolved
Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just had a minor question on semantics 👍

Copy link
Collaborator

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kclowes kclowes merged commit 3de3e8d into ethereum:master Jul 6, 2022
@kclowes kclowes deleted the add-black branch July 6, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants