Upgrade template, resigning Unverified commit #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update template
See an example issue here: ethereum/eth-account#150
Show full explanation for pydocstyle failures
* Add breaking change type to newsfragment * Move breaking-change -> breaking
Frankly not sure why recursive-exclude doesn't work here, but prune does, and that's good enough for me now. It's also probably preferable to only exclude venv* at the root, anyway.
Use updated CircleCI images
Exclude huge and unnecessary venv*/ from dist
Upgrade towncrier to fix the duplicate title bug
It can get big with installed libraries. On a relatively small release of eth-portal, this one change cut the .tar.gz release size from 574Kb to 14Kb.
Don't push .tox file to tar.gz release
* Tweaks to release process * Drop python 3.6
toxinidir won't mean anything in a Makefile
Upgrade isort
- Clean up github PR template to remove double links to the newsfragment README.md - Clean up some typos and make some minor refactors.
- It is not recommended to invoke ``setup.py`` directly, instead opting for ``python -m build`` for the commands in this commit (see: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html) - Add newsfragment for #70
Do not invoke `setup.py` directly; minor refactor + cleanup
* new issue and pr templates
* convert bash scripts to py
* bump versions in dependencies and ci builds * move tox to [dev] per issue ethereum#34 * move RTD deps pointer into .readthedocs.yml * unpin flake8 add flake8-bugbear to lint deps
* remove gitter, testing setup, and pandoc sections, add quotes to dev install
* repin flake8, bump tox to >=4.0.0 as that's where whitelist was deprecated, misc updates
* template cleanup following initial merge with py-evm * add flake8 pin comment * correct license years * add pin note to mypy
* apply template updates found following merge with eth-typing * add build as a dev dependency * remove timeout from pytest.ini, it doesn't do anything without pytest-timeout as a dep
* add updates found when merging template with py-ssz and eth-abi * add wheel and wheel-windows to ci and reorg
* remove testall because it doesnt work
pacrob
force-pushed
the
upgrade-template-all-commits-verified
branch
2 times, most recently
from
96f48c2
to
ae65fc7
Compare
pacrob
force-pushed
the
upgrade-template-all-commits-verified
branch
2 times, most recently
from
91e03c8
to
a6d5110
Compare
pacrob
changed the title
pacrob
force-pushed
the
upgrade-template-all-commits-verified
branch
2 times, most recently
from
eb5e1d6
to
7608378
Compare
kclowes
reviewed
May 3, 2023
pacrob
force-pushed
the
upgrade-template-all-commits-verified
branch
from
3b04096
to
48edc1d
Compare
pacrob
force-pushed
the
upgrade-template-all-commits-verified
branch
from
48edc1d
to
f41913b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The project template was updated. This pulls in those changes. This is a re-do of PR #49 , re-signing what is now commit fe19f5a with a valid gpg key
Cute Animal Picture