New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade template #53
Merged
Merged
Upgrade template #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor formatting updates, remove additional docs to separate pr
bump sphinx version and set py version rtd uses to 3.8
change references to doc to all be docs
Pre-release check for upstream configuration of remote
add `.venv*` to .gitignore
add `.build` to be ignored
fix indent, add sphinx fail_on_warning
gitignore local vs-code settings
* add pre-commit * run pre-commit * skip lint on README.md as it breaks template filling
fix linting broke template formatting
missing doublequote
Add description of pydocstyle D415 rule
drop pytest-watch from dev dependencies
- Sometimes 'www.' is used in the url for https
Makefile updates
* Ignore all __pycache__ directories * Newsfragment * Revert Newsfragment
Causes problems with releasing when pre-commit changes the file after bumpversion updates it
pacrob
force-pushed
the
upgrade-template
branch
13 times, most recently
from
December 8, 2023 22:28
0ea105d
to
0860758
Compare
pacrob
force-pushed
the
upgrade-template
branch
from
December 8, 2023 22:34
0860758
to
9ca2bea
Compare
reedsa
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
kclowes
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
pacrob
force-pushed
the
upgrade-template
branch
from
December 13, 2023 17:28
b93394c
to
4013308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Updates from the project template, notably:
pre-commit
for lintingmaster
branch tomain
.How was it fixed?
Todo:
Clean up commit history
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture