Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade template #53

Merged
merged 36 commits into from Dec 13, 2023
Merged

Upgrade template #53

merged 36 commits into from Dec 13, 2023

Conversation

pacrob
Copy link
Collaborator

@pacrob pacrob commented Dec 8, 2023

What was wrong?

Updates from the project template, notably:

  • drop python 3.7 support
  • use pre-commit for linting
  • change the name of the master branch to main.

How was it fixed?

Todo:

  • Clean up commit history

  • Add or update documentation related to these changes

  • Add entry to the release notes

Cute Animal Picture

image

pacrob and others added 30 commits May 1, 2023 16:29
minor formatting updates, remove additional docs to separate pr
bump sphinx version and set py version rtd uses to 3.8
change references to doc to all be docs
Pre-release check for upstream configuration of remote
add `.venv*` to .gitignore
add `.build` to be ignored
fix indent, add sphinx fail_on_warning
gitignore local vs-code settings
* add pre-commit

* run pre-commit

* skip lint on README.md as it breaks template filling
fix linting broke template formatting
missing doublequote
Add description of pydocstyle D415 rule
drop pytest-watch from dev dependencies
- Sometimes 'www.' is used in the url for https
reedsa and others added 4 commits November 27, 2023 15:51
* Ignore all __pycache__ directories

* Newsfragment

* Revert Newsfragment
Causes problems with releasing when pre-commit changes the file after bumpversion updates it
@pacrob pacrob force-pushed the upgrade-template branch 13 times, most recently from 0ea105d to 0860758 Compare December 8, 2023 22:28
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

.circleci/config.yml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
setup.py Show resolved Hide resolved
@pacrob pacrob merged commit 52bf2ae into ethereum:main Dec 13, 2023
24 checks passed
@pacrob pacrob deleted the upgrade-template branch December 13, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants