Propagate block bodies #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grab full transactions so that we don't have to retrieve them one at a time. But then we don't get the transaction hashes, to use when getting receipts. So we build the hashes manually now, reusing the transaction encoding from when we build the block bodies.
carver
force-pushed
the
propagate-block-bodies
branch
from
914921c
to
b14bca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull the full transactions when getting a block, and grab the extra uncle headers. Then package up and push them to trin.
Because we are pulling full transactions now, we don't get the hashes for free. So now, decode transactions once, use the hashes of them to request receipts.
Bonus fix: decode transactions from web3 when they create contracts (
tofield is empty).To-Do
Cute Animal Picture