Upgrade template #16
Merged
Upgrade template #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest mypy refuses package with file path
It has weird capitalization rules, in particular.
Collection of updates
Add IDE filenames to .gitignore
Export type annotations to importing projects
A bunch of little patches
Fix the type annotations export, adding py.typed
Update template
See an example issue here: ethereum/eth-account#150
Show full explanation for pydocstyle failures
* Add breaking change type to newsfragment * Move breaking-change -> breaking
Frankly not sure why recursive-exclude doesn't work here, but prune does, and that's good enough for me now. It's also probably preferable to only exclude venv* at the root, anyway.
gitignore local vs-code settings
* add pre-commit * run pre-commit * skip lint on README.md as it breaks template filling
fix linting broke template formatting
missing doublequote
Add description of pydocstyle D415 rule
drop pytest-watch from dev dependencies
- Sometimes 'www.' is used in the url for https
Makefile updates
* Ignore all __pycache__ directories * Newsfragment * Revert Newsfragment
pacrob
force-pushed
the
upgrade-template
branch
from
72d14ea
to
236c6e0
Compare
pacrob
force-pushed
the
upgrade-template
branch
from
236c6e0
to
da77368
Compare
kclowes
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you do?
Many updates from the project template, notably:
masterbranch tomainOnly running CI on
rlp-v0for py38 and py39, as the way it importssequencefromcollectionsis gone as of py310 - https://stackoverflow.com/questions/73491058/importerror-cannot-import-name-sequence-from-collections-usr-lib-python3To-Do
Cute Animal Picture