Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 is missing in release notes #11

Closed
ulope opened this issue Dec 7, 2018 · 2 comments
Closed

v2.0.0 is missing in release notes #11

ulope opened this issue Dec 7, 2018 · 2 comments

Comments

@ulope
Copy link
Member

ulope commented Dec 7, 2018

What was wrong?

There is no mention of v2.0.0 (and if there are any incompatibilities) in the release notes.

@carver
Copy link
Contributor

carver commented Dec 11, 2018

AFAIK the only "incompatibility" is that mypy wasn't actually enforcing any of the types because we were missing this line:

package_data={'eth_typing': ['py.typed']},

So making upgrading to v2 might cause mypy to start erroring out. We have been able to upgrade to eth-typing v2 in most modules without any impact, though.

Naturally, 👍 for adding a note about this to the docs.

@cburgdorf
Copy link
Contributor

I added the missing release notes. I also created an issue to upgrade this repo to use towncrier #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants