Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new type for BLS private key #23

Merged
merged 2 commits into from Jun 20, 2022

Conversation

ralexstokes
Copy link
Member

What was wrong?

Various parts of the eth2.0 ecosystem will reference a BLS private key, e.g. a validator needing to sign a block for broadcast.

How was it fixed?

Adding a NewType for a BLSPrivateKey

Cute Animal Picture

put a cute animal picture link inside the parentheses

pipermerriam pushed a commit to pipermerriam/eth-typing that referenced this pull request Sep 2, 2020
Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been here a while 👀 ... better late than never... lgtm 👍

@fselmo fselmo merged commit 96a7e53 into ethereum:master Jun 20, 2022
@ralexstokes ralexstokes deleted the add-bls-privkey-type branch June 21, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants