Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use __all__ in __init__.py #28

Merged
merged 1 commit into from Jun 20, 2022
Merged

Use __all__ in __init__.py #28

merged 1 commit into from Jun 20, 2022

Conversation

sobolevn
Copy link
Contributor

What was wrong?

Mypy was raising "undefined name" with --no-implicit-reexport flag.

How was it fixed?

Defining __all__ is good enough.
It also allows to remove noqa from flake8.

Cute Animal Picture

put a cute animal picture link inside the parentheses

@sobolevn
Copy link
Contributor Author

This looks unrelated: https://circleci.com/gh/ethereum/eth-typing/495?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Extension error:
Could not import extension sphinx.builders.latex (exception: cannot import name 'contextfunction' from 'jinja2' (/home/circleci/repo/.tox/doctest/lib/python3.8/site-packages/jinja2/__init__.py))
make: *** [Makefile:165: doctest] Error 2
make: Leaving directory '/home/circleci/repo/docs'
ERROR: InvocationError for command /usr/bin/make -C docs doctest (exited with code 2)
___________________________________ summary ____________________________________
ERROR:   doctest: commands failed


Exited with code exit status 1

[fselmo]: Rebased and included the BLSPrivateKey in these changes.

Co-authored-by: Felipe Selmo <fselmo2@gmail.com>
Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@fselmo fselmo merged commit 56db64b into ethereum:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants