Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the upper cap on Python version to 4.0 #37

Merged
merged 2 commits into from Sep 14, 2022

Conversation

fjarri
Copy link
Contributor

@fjarri fjarri commented Aug 27, 2022

What was wrong?

  • eth-typing, seemingly the only one of the eth-* family of packages, has the cap on Python version set to <3.11. eth-account, eth-utils, eth-abi have it at <4. Unless there is something special about eth-typing that I am missing, it would be more consistent to set its cap to <4 as well.
  • A cap on minor Python version creates problems with dependency resolvers, since any user of the library has to also set the same upper cap to make the resolution work, thus propagating this decision.
  • A minor release of Python is very unlikely to break something in an at least occasionally maintained package, since deprecations are rare, and each is announced several minor versions before it goes in effect.

How was it fixed?

Upper cap on Python set to <4.

Note: it seems that the cap was introduced in b5e23be, for an unspecified reason.

@fjarri
Copy link
Contributor Author

fjarri commented Sep 2, 2022

A polite bump. Are there any concerns about removing the cap?

@kclowes
Copy link
Contributor

kclowes commented Sep 14, 2022

Thanks for the bump. I don't have any concerns with removing the cap. I'll add a newsfragment and merge!

Copy link
Contributor

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kclowes kclowes merged commit 2b679d8 into ethereum:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants