Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Cancun" fork to ForkName #45

Merged
merged 2 commits into from Apr 26, 2023
Merged

Add "Cancun" fork to ForkName #45

merged 2 commits into from Apr 26, 2023

Conversation

fselmo
Copy link
Contributor

@fselmo fselmo commented Apr 24, 2023 •
edited

What was wrong?

  • Cancun fork name missing from ForkName enum

How was it fixed?

  • Add it

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@fselmo fselmo requested review from kclowes and pacrob April 24, 2023 21:35
pacrob
pacrob approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

kclowes
kclowes approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 !

@fselmo fselmo merged commit e7b9fe6 into ethereum:master Apr 26, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacrob pacrob pacrob approved these changes

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fselmo @pacrob @kclowes