Extend and more properly define typing for BlockIdentifier #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
extend-typing-for-block-identifier
branch
from
2e5074a
to
be23076
Compare
- Borrowing from the typing used in web3.py, where it has worked quite well, ``BlockIdentifer`` needed some modernizing that would be nice to use across libraries. eth-tester could benefit once type hinting is introduced there.
fselmo
force-pushed
the
extend-typing-for-block-identifier
branch
from
be23076
to
bb75480
Compare
- Use the same versioning as web3.py. This will be removed in a few months for the next major release since python 3.7 is unsupported as of yesterday.
fselmo
force-pushed
the
extend-typing-for-block-identifier
branch
from
82f1ce2
to
2b5acfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
BlockIdentifierdoes not cover all possible cases, such asBlockParamsHow was it fixed?
BlockIdentiferneeded some modernizing in this library that would be nice to use across other libraries. eth-tester could benefit once type hinting is introduced there.Todo:
Cute Animal Picture