Upgrade template #57
Upgrade template #57
Conversation
clean up test_import_and_version
clean up test_import_and_version
Drop the `install pre-commit` step here, as it is installed for all linting ci via the tox env deps
Add `pre-commit install` here since it was removed from ci config
pacrob
force-pushed
the
upgrade-template
branch
from
724c2bf
to
73b6a68
Compare
| py{38,39,310,311,312}-core | ||
| py{38,39,310,311,312}-lint | ||
| py{38,39,310,311,312}-wheel | ||
| windows-wheel |
There was a problem hiding this comment.
maybe:
| windows-wheel | |
| py{311,312}-windows-wheel |
for consistency?
There was a problem hiding this comment.
As it is, it just keeps circleci config drier. See .circleci/config.yml -> windows-wheel-steps -> windows-wheel-setup. If specified different TOXENVs, the whole windows-wheel-setup step would need to be duplicated for each job. Happy to make the change if you think it helps with clarity.
There was a problem hiding this comment.
Nah, I think it's good as-is. ✨
| rev: v0.2.4 | ||
| hooks: | ||
| - id: blocklint | ||
| exclude: 'docs/Makefile|docs/release_notes.rst|tox.ini' |
There was a problem hiding this comment.
Does this find all other files in the repo? I think I was trying with listing directories to include but if this works I like it better.
There was a problem hiding this comment.
I've tried sticking blocked words in various files and it hasn't missed one yet.
What was wrong?
Python project template updates, notably adding py312 support.
Test repo for adding blocklint to our linting lineup.
Todo:
Clean up commit history
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture