ABI types for utils #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedsa
added a commit
to reedsa/eth-typing
that referenced
this pull request
Apr 8, 2024
pacrob
reviewed
Apr 9, 2024
There was a problem hiding this comment.
It seems like it would be helpful to list the fields and their types in the docs for reference. Otherwise the user has to go to code too. What you think?
Edit: the docs already have autodoc in there, so you could add the definition as a docstring and have it construct the docs for you.
reedsa
added a commit
to reedsa/eth-typing
that referenced
this pull request
Apr 9, 2024
reedsa
added a commit
to reedsa/eth-typing
that referenced
this pull request
Apr 10, 2024
reedsa
added a commit
to reedsa/eth-typing
that referenced
this pull request
Apr 10, 2024
pacrob
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #
Closes #
How was it fixed?
Types for elements of a contract ABI. These were lifted from web3.py to be usable in
eth-utils.Updates in web3.py and eth-utils inbound.
Todo:
Clean up commit history
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture