Add humanize bytes utility #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a small number of linting changes that black made (new black version). I segregated them into their own commit and included them here. |
njgheorghita
approved these changes
Apr 28, 2020
docs/utilities.rst
Outdated
|
|
||
| Returns the provided byte string in a human readable format. | ||
|
|
||
| If the value is 5 bytes or shorted it is returned in full in its hexidecimal representation (without a ``0x`` prefix) |
docs/utilities.rst
Outdated
|
|
||
| If the value is 5 bytes or shorted it is returned in full in its hexidecimal representation (without a ``0x`` prefix) | ||
|
|
||
| If the value is longer that 5 bytes it is returne in its hexidecimal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The
humanize_hashfunction was useful for things that are consistently 32 bytes long but it didn't work well for variable length byte strings since 1) the input value is typed asHash32and 2) it doesn't work correctly for short byte strings..How was it fixed?
Added a
humanize_bytesthat is more general case and handles short byte strings appropriately.To-Do
Cute Animal Picture