Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Check for already sent deposits on deposit page. #165

Open
Belkaar opened this issue Aug 16, 2020 · 3 comments
Open

Feature request: Check for already sent deposits on deposit page. #165

Belkaar opened this issue Aug 16, 2020 · 3 comments

Comments

@Belkaar
Copy link

Belkaar commented Aug 16, 2020

Problem: If the deposit process for multiple validators is aborted and then started again by uploading the json file again the launchpad will send the eht again.

Maybe it could check which deposits are already made and not offer those transactions.

@emansipater
Copy link

I would almost call this a bug and not a feature request. There are plenty of very good reasons a user might have to stop and restart the deposit process: not enough ETH in wallet, browser/computer/internet/etc issues, and so on. The expected behaviour should be that the page shows the same deposit indications even if the user has been forced to close it and re-upload the json in order to resume depositing. See ethereum/ethereum-org-website#1581

@emansipater
Copy link

See #166 for an example of a user reporting exactly the issue that results. There is no warning and significant consequences. In my mind that makes it a bug.

@pk27734
Copy link

pk27734 commented Nov 2, 2020

This has been a major issue for me when joining Medalla, causing multiple deposits (96 ETH) in the contract for one validator and two other validators never being able to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants