Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add finalized descendant check to beacon_block pubsub #1964

Closed
terencechain opened this issue Jul 10, 2020 · 3 comments
Closed

Add finalized descendant check to beacon_block pubsub #1964

terencechain opened this issue Jul 10, 2020 · 3 comments

Comments

@terencechain
Copy link
Contributor

terencechain commented Jul 10, 2020 •
edited

Chatting with @prestonvanloon, we think it'll be a great addition to include validation of finalized block descent check as part of beacon_block's p2p propagation criteria. In short, to re-propagate the block, we should satisfy the following:

assert get_ancestor(store, block.parent_root, finalized_slot) == store.finalized_checkpoint.root

We have been observing more propagations of bad blocks in Onyx. Those bad blocks are attributed to not descendant of local finalized block.
@prestonvanloon prestonvanloon mentioned this issue Jul 10, 2020
Merged
@prestonvanloon
Copy link
Contributor

Related: #1959

Maybe a duplicate too, i'm not sure.

@djrtwo
Copy link
Contributor

djrtwo commented Jul 14, 2020

closing in favor of #1959

@djrtwo djrtwo closed this as completed Jul 14, 2020
@djrtwo
Copy link
Contributor

djrtwo commented Jul 14, 2020

closing in favor of #1959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@djrtwo @prestonvanloon @terencechain